Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I've never even worked with a code review process where outright rejecting PRs is a normal part of the process for anything other than external contributions. The normal process is more of that if you think a PR is a bad idea it's up to you to persuade the author of that. You'll certainly sometimes have the author withdraw the PR without being truly convinced, but something like "I don't like this. Rejected." would just be disregarded if you can get other people to approve it.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: